fix(server): explicitly set content-type to text/html for requests to /api #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
changed the title
magurotuna
force-pushed
the
magurotuna/content-type-for-api
branch
from
e7ee20b to
d751d30
Compare
magurotuna
commented
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a custom middleware to overwrite content-type in the response header with
text/htmlfor all requests to/apiexcept for CSS and JS.This helps avoid the MIME type detection errors that happen with some file names such as
Deno.Kv.prototype.list.Fixes #609
Fixes #607
With the local dev server I confirmed that Deno.Kv.prototype.list is rendered correctly and content-type in the response header is set to text/html.