Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Updates #597

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Navigation Updates #597

merged 2 commits into from
Jul 16, 2024

Conversation

donjo
Copy link
Member

@donjo donjo commented Jul 15, 2024

This PR updates a number of nav styles on both the top nav and side nav

Top Nav

  • Content is re-arranged to group runtime and deploy content
  • Style changes to fix alignment at different mobile viewports
  • More subtle active state accent underlines
  • Search box resizing
  • Slight spacing adjustments around logo

Table of contents (API Ref)

  • Removed header since there is only one section of content and every item is in that section
  • Spacing changes to adjust for that.
  • ToC width reduced since the table of contents only provides one level of navigation with no subnav content and thus don't utilize the arrow > icon like the rest of the docs do.

Other

  • Body content spacing adjustments to account for changes to ToC
Screenshot 2024-07-15 at 4 29 14 PM

@donjo donjo requested a review from crowlKats July 15, 2024 21:16
ry
ry reviewed Jul 16, 2024
View reviewed changes
_components/Header.tsx Outdated
Comment on lines 46 to 49
name="Deno Runtime"
name="Runtime"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Runtime" or "Manual"? "Runtime Manual" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Runtime Manual a bit better I think

ry
ry approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donjo donjo merged commit d6b497e into main Jul 16, 2024
5 checks passed
@donjo donjo mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donjo @ry