Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(task): do not propagate env changes outside subshells #24279

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix(task): do not propagate env changes outside subshells #24279

merged 2 commits into from
Jun 20, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret requested a review from lucacasonato June 19, 2024 23:33
@dsherret dsherret enabled auto-merge (squash) June 19, 2024 23:33
@dsherret dsherret merged commit b62534d into denoland:main Jun 20, 2024
17 checks passed
@dsherret dsherret deleted the fix_subshell_env_changes branch June 21, 2024 22:50
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
@dsherret @sbmsr
fix(task): do not propagate env changes outside subshells (denoland#2…
9cc7183 
…4279)

* denoland/deno_task_shell#120
@sbmsr sbmsr mentioned this pull request Jul 2, 2024
Closed
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@dsherret @zebreus
fix(task): do not propagate env changes outside subshells (denoland#2…
5ffa8ff 
…4279)

* denoland/deno_task_shell#120
@dsherret dsherret mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju