fix: Add sys permission kinds for node compat #24242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamgreg
force-pushed
the
sys-kinds-for-node
branch
from
d0b5d4f to
518a2b4
Compare
adamgreg
force-pushed
the
sys-kinds-for-node
branch
from
518a2b4 to
0ea60f1
Compare
|
Hi @bartlomieju I'm not sure why that test fails - it passes locally, and doesn't seem to relate to "sys" permissions. Can you recommend anything I should do please? It's my first time trying to contribute to the Rust codebase. |
bartlomieju
reviewed
Jun 25, 2024
* Support "statfs", "username", "getPriority" and "setPriority". * Check username permission in node:os.userInfo() instead of unknown "userInfo" permission. * Check for "uid" permission in node:process.geteuid() instead of "geteuid". * Add missing "homedir" to SysPermissionDescriptor.kind union
adamgreg
force-pushed
the
sys-kinds-for-node
branch
from
df82577 to
a38a3ca
Compare
|
Hi, is there still a problem with this, or could it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24241
--allow-sys.node:os.userInfo()instead of a single "userInfo" permission.node:process.geteuid()instead of "geteuid".SysPermissionDescriptor.kindunion