fix(core): avoid op_state.borrow_mut() for OpsTracker #12525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By allowing interior mutability in
OpsTracker
(owning aRefCell<Vec>
instead of just aVec
)Fixes #12453
High level test
Notes
Missing a unit test of an async-op borrowing OpState across an awaitBorrowMutError
#12453 could happen if OpState is mutably borrowed across an await (took a quick look and didn't see any instances of it in the codebase)