feat(serde_v8): StringOrBuffer #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializes ArrayBufferViews to Vec<u8> when using deserialize_any (e.g: untagged serde enums)
similar to ByteString and ZeroCopyBuf types
Comment on lines
+137
to
+144
| ValueType::ArrayBufferView => { | ||
| v8::Local::<v8::ArrayBufferView>::try_from(self.input) | ||
| .and_then(|view| { | ||
| magic::zero_copy_buf::ZeroCopyBuf::try_new(self.scope, view) | ||
| }) | ||
| .map_err(|_| Error::ExpectedInteger) | ||
| .and_then(|zb| visitor.visit_byte_buf(Vec::from(&*zb))) | ||
| } |
There was a problem hiding this comment.
Note: this is safe because it does a memcpy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializes
ArrayBufferViews toVec<u8>when usingdeserialize_any(e.g: untagged serde enums)Implements
StringOrBuffertype for optimizations like #12451 (encoding the strings directly in the op-layer during opcall thus avoiding acore.encode()call upfront)Note: unlike
ZeroCopyBuf,StringOrBufferis read-only and copies/owns its data