Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: various op cleanup #12329

Merged
merged 3 commits into from
Oct 5, 2021
Merged

chore: various op cleanup #12329

merged 3 commits into from
Oct 5, 2021

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Oct 5, 2021 •
edited
Loading

Primarily just gets rid of the Option<ZeroCopyBuf> and the ok_or_else for it which is the first thing in ops which stems from the first iteration of ZeroCopyBuf support, but doesn't make much sense anymore now.

For the webgpu related changes i will open up a PR at wgpu as well

AaronO
AaronO approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronO AaronO merged commit 77a00ce into denoland:main Oct 5, 2021
@crowlKats crowlKats deleted the op_cleanup branch October 5, 2021 21:13
@crowlKats crowlKats mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crowlKats @AaronO