Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View components: admin menus #1096

Merged
merged 25 commits into from
May 7, 2021
Merged

View components: admin menus #1096

merged 25 commits into from
May 7, 2021

Conversation

denny
Copy link
Owner

@denny denny commented May 4, 2021 •
edited
Loading

Adding View Components, and using them to replace all of the partials previously involved in generating the main menu in the admin area sidebar.

@codecov
Copy link

codecov bot commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #1096 (3317579) into main (4f90075) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main     #1096    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          361       381    +20     
  Lines         5208      5348   +140     
==========================================
+ Hits          5208      5348   +140
Impacted Files Coverage Δ
...nents/shiny_access/admin/menu/section_component.rb 100.00% <100.00%> (ø)
...ponents/shiny_blog/admin/menu/section_component.rb 100.00% <100.00%> (ø)
.../shinycms/admin/menu/consent_versions_component.rb 100.00% <100.00%> (ø)
...ponents/shinycms/admin/menu/coverband_component.rb 100.00% <100.00%> (ø)
.../components/shinycms/admin/menu/email_component.rb 100.00% <100.00%> (ø)
...p/components/shinycms/admin/menu/item_component.rb 100.00% <100.00%> (ø)
.../components/shinycms/admin/menu/other_component.rb 100.00% <100.00%> (ø)
...omponents/shinycms/admin/menu/section_component.rb 100.00% <100.00%> (ø)
...mponents/shinycms/admin/menu/settings_component.rb 100.00% <100.00%> (ø)
...omponents/shinycms/admin/menu/sidekiq_component.rb 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f90075...3317579. Read the comment docs.

@denny denny added core plugin Involves the core 'ShinyCMS' plugin feature plugins Involves one or more of the non-core plugins html / css Involves HTML and/or CSS major Big (or otherwise significant) pieces of work ruby Involves Ruby code work-in-progress WIP - do not merge labels May 4, 2021
@denny denny removed the work-in-progress WIP - do not merge label May 7, 2021
@denny denny merged commit ef432eb into main May 7, 2021
@denny denny deleted the dev/view-components/admin-menus branch May 7, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core plugin Involves the core 'ShinyCMS' plugin feature plugins Involves one or more of the non-core plugins html / css Involves HTML and/or CSS major Big (or otherwise significant) pieces of work ruby Involves Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denny