Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvements for Halcyonic theme #1088

Merged
merged 10 commits into from
Apr 29, 2021
Merged

Accessibility improvements for Halcyonic theme #1088

merged 10 commits into from
Apr 29, 2021

Conversation

denny
Copy link
Owner

@denny denny commented Apr 29, 2021

  • Alt text inputs for index template images
  • Accessibly hidden labels for login, search, and newsletter subscribe forms

@denny denny added minor Small (or otherwise trivial) changes html / css Involves HTML and/or CSS demo-site About the demo site data or rake task themes About a theme, or the code that supports themes accessibility labels Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #1088 (2e1af41) into main (8e7267f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              main     #1088    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          318       361    +43     
  Lines         4582      5209   +627     
==========================================
+ Hits          4582      5209   +627
Impacted Files Coverage Δ
...ugins/ShinyCMS/lib/tasks/support/demo_site_task.rb 100.00% <ø> (ø)
...ublic/models/concerns/shinycms/template_element.rb 100.00% <0.00%> (ø)
...MS/app/public/models/concerns/shinycms/has_slug.rb 100.00% <0.00%> (ø)
...app/public/controllers/shinycms/base_controller.rb 100.00% <0.00%> (ø)
...ollers/concerns/shinycms/admin/with_discussions.rb 100.00% <0.00%> (ø)
...CMS/app/public/models/concerns/shinycms/element.rb 100.00% <0.00%> (ø)
...p/public/models/concerns/shinycms/mjml_template.rb 100.00% <0.00%> (ø)
...blic/models/concerns/shinycms/has_readable_name.rb 100.00% <0.00%> (ø)
...inyCMS/app/public/models/concerns/shinycms/post.rb 100.00% <0.00%> (ø)
...s/concerns/shinycms/admin/with_date_time_inputs.rb 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7267f...2e1af41. Read the comment docs.

@denny denny merged commit 59e050c into main Apr 29, 2021
@denny
Copy link
Owner Author

denny commented Apr 29, 2021

More to do here! Update template data, update demo data, check rest of templates and forms for similar issues, ...

@denny denny mentioned this pull request May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility demo-site About the demo site data or rake task html / css Involves HTML and/or CSS minor Small (or otherwise trivial) changes themes About a theme, or the code that supports themes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denny