Implement multi arch docker build #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linzhou-db I saw a single arm docker image released with 0.6.8 and 0.7.0. Previous versions only had amd images. I suspect the server/docker:publish is run from a developers machine which causes this behaviour. Please correct me if I;m wrong but I could not find the release proces for the docker images. This PR makes sure both architectures are published |
|
@linzhou-db @dennyglee Could you please have a look at this one? It's a small change to create multi arch docker images for the delta sharing reference impl. Thx in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the docker build part of #252 No issues using this docker container on my M2 mac.
If you want to verify the build result I did a ./build/sbt server/docker:publish to my own docker hub account results are here: https://hub.docker.com/repository/docker/krisgeus/delta-sharing-server/tags?page=1&ordering=last_updated