Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward the error message of the failed task to the screen #388

Merged
merged 5 commits into from
Oct 21, 2023
Merged

forward the error message of the failed task to the screen #388

merged 5 commits into from
Oct 21, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 21, 2023

Fix #333.

@njzjz
forward the error message of failed task to the screen
c787ab6 
Fix deepmodeling#333.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review October 21, 2023 07:37
pre-commit-ci bot and others added 2 commits October 21, 2023 07:37
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
70d7437 
for more information, see https://pre-commit.ci
@njzjz
apply the change to SlurmJobArray
ee6e9e8 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Oct 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6d9660) 70.76% compared to head (0b16692) 57.64%.
Report is 1 commits behind head on master.

❗ Current head 0b16692 differs from pull request most recent head 0af97e8. Consider uploading reports for the commit 0af97e8 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #388       +/-   ##
===========================================
- Coverage   70.76%   57.64%   -13.12%     
===========================================
  Files          31       31               
  Lines        3530     3544       +14     
===========================================
- Hits         2498     2043      -455     
- Misses       1032     1501      +469
Files Coverage Δ
dpdispatcher/machine.py 88.15% <100.00%> (+0.05%) ⬆️
dpdispatcher/slurm.py 80.31% <100.00%> (+1.17%) ⬆️
dpdispatcher/submission.py 89.47% <100.00%> (+0.25%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz temporarily deployed to bohrium October 21, 2023 07:44 — with GitHub Actions Inactive
@njzjz
improve tests
b0680d0 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz temporarily deployed to bohrium October 21, 2023 08:06 — with GitHub Actions Inactive
@njzjz
skip assert on macos
0af97e8 
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz enabled auto-merge (squash) October 21, 2023 08:42
@njzjz njzjz merged commit 94a0756 into deepmodeling:master Oct 21, 2023
26 checks passed
@njzjz njzjz deleted the forward-err-msg branch October 21, 2023 08:43
@njzjz njzjz mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forward the error message of failed task to the screen
1 participant
@njzjz