Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: recover default remote_root to None #381

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 19, 2023

Fix regression caused by #370.

Fix regression caused by deepmodeling#370.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7de5f72) 57.42% compared to head (fba51c5) 57.40%.

❗ Current head fba51c5 differs from pull request most recent head beeaba6. Consider uploading reports for the commit beeaba6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   57.42%   57.40%   -0.02%     
==========================================
  Files          31       31              
  Lines        3502     3503       +1     
==========================================
  Hits         2011     2011              
- Misses       1491     1492       +1     
Files Coverage Δ
dpdispatcher/ssh_context.py 80.13% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz merged commit 9720760 into deepmodeling:master Oct 19, 2023
25 checks passed
@njzjz njzjz deleted the fix-370 branch October 19, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant