python-package: Add build system requirements for correct installation #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks, Is it working well for both Linux and Windows? |
|
Can confirm it works with
Windows:
With a pure python environment in all cases I think it is enough |
|
Thanks, I will publish to PyPI later. |
theparitt
pushed a commit
to theparitt/insightface
that referenced
this pull request
Apr 4, 2024
python-package: Add build system requirements for correct installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The known issue is that
insightfacepackage requires Cython and NumPy as prerequisites for installation.Previously, the solution was only a mention about this in the readme (#1976)
But actually, these requirements can be added as "build system requirements" for the setuptools with pyproject.toml, to be installed before actual package installation.
This allows the package to be installed from sdist using only
pip install insightface onnxruntimewithout any prerequisites steps.Also, I'm not sure if I should bump the version of the package because of this change, so please feel free to decrease it back if the criteria for version increase are different.