Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec on bulk change taxonomies #13724

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Dec 4, 2024

🎩 What? Why?

Fix a flaky spec when checking a bulk taxonomies assignation

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

Copy link

request-info bot commented Dec 4, 2024

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

@andreslucena andreslucena added flaky spec type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Dec 4, 2024
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Dec 4, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Running against develop, i got a failure after 7th request.
Running against this branch, there were no failures after 40 requests.

@alecslupu alecslupu merged commit 24568e5 into develop Dec 4, 2024
55 of 56 checks passed
@alecslupu alecslupu deleted the fix/project-taxonomies-flaky branch December 4, 2024 23:52
@alecslupu alecslupu added this to the 0.30.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky spec no-backport Pull Requests that should not be backported type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants