Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update open data exports for Budgets projects #13675

Merged
merged 30 commits into from
Dec 16, 2024

Conversation

greenwoodt
Copy link
Contributor

@greenwoodt greenwoodt commented Nov 18, 2024

🎩 What? Why?

Update of columns for the csv_export of the Projects component. This is a part of on going work in Ref: MGOV06

📌 Related Issues

Testing

  1. Load the branch locally
  2. rebuild the development_app
  3. Launch app locally to the browser
  4. Head to the footer and find & click the "Open Data" link
  5. Download Projects CSV
  6. See newly added columns

run decidim-budgets/spec/serializers/project_serializer_spec.rb

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: budgets type: change PRs that implement a change for an existing feature labels Nov 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 18, 2024
@andreslucena andreslucena changed the title Projects OpenData CSV export update Update open data exports for Budgets' projects Nov 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 19, 2024
@greenwoodt greenwoodt marked this pull request as ready for review November 19, 2024 15:19
@greenwoodt greenwoodt added the contract: 2024-flatfiles Metagov grant label Nov 20, 2024
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 5, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftovers to clean and a few details and we're ready for the merge

decidim-budgets/config/locales/en.yml Outdated Show resolved Hide resolved
decidim-budgets/config/locales/en.yml Outdated Show resolved Hide resolved
decidim-budgets/lib/decidim/budgets/project_serializer.rb Outdated Show resolved Hide resolved
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
greenwoodt and others added 3 commits December 9, 2024 10:29
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2024
@greenwoodt greenwoodt changed the title Update open data exports for Budgets' projects Update open data exports for Budgets projects Dec 11, 2024
@andreslucena
Copy link
Member

@greenwoodt can you fix the conflict? Thanks

@greenwoodt
Copy link
Contributor Author

@greenwoodt can you fix the conflict? Thanks

Done!

@andreslucena andreslucena merged commit 8c0261e into decidim:develop Dec 16, 2024
44 checks passed
antopalidi pushed a commit that referenced this pull request Dec 16, 2024
* updated_at column added.

* updated_at column fixed and test added

* reference column and test added

* author field extracted from debates and added to projects

* methods extracted  to retrieve the author user profile

* renamed the budget id to decidim_budgets_budget_id

* selected_at added including its test

* follows_count extraction and added with test

* longitude and latitude extratced with tests added

* translations added and updated

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-budgets/lib/decidim/budgets/project_serializer.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* reverted id and added budget title

* extracted root_url helper for rspec test

* extratced the budget url with test

* translations updated for budget_url

* extracted method to retrieve budget url

* added test to get URL of budget

* removed unused methods from spec

* added title of budget

* Improved the budget component serializer. id, url and title added to hash with test suite

* updated i18n translations

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-budgets/lib/decidim/budgets/project_serializer.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update decidim-budgets/spec/serializers/project_serializer_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: 2024-flatfiles Metagov grant module: budgets type: change PRs that implement a change for an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants