-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update open data exports for Budgets projects #13675
Merged
andreslucena
merged 30 commits into
decidim:develop
from
greenwoodt:change/csv-exports-projects
Dec 16, 2024
Merged
Update open data exports for Budgets projects #13675
andreslucena
merged 30 commits into
decidim:develop
from
greenwoodt:change/csv-exports-projects
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenwoodt
added
module: budgets
type: change
PRs that implement a change for an existing feature
labels
Nov 18, 2024
andreslucena
changed the title
Projects OpenData CSV export update
Update open data exports for Budgets' projects
Nov 18, 2024
13 tasks
andreslucena
requested changes
Nov 20, 2024
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some leftovers to clean and a few details and we're ready for the merge
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
greenwoodt
changed the title
Update open data exports for Budgets' projects
Update open data exports for Budgets projects
Dec 11, 2024
@greenwoodt can you fix the conflict? Thanks |
Done! |
andreslucena
approved these changes
Dec 16, 2024
antopalidi
pushed a commit
that referenced
this pull request
Dec 16, 2024
* updated_at column added. * updated_at column fixed and test added * reference column and test added * author field extracted from debates and added to projects * methods extracted to retrieve the author user profile * renamed the budget id to decidim_budgets_budget_id * selected_at added including its test * follows_count extraction and added with test * longitude and latitude extratced with tests added * translations added and updated * Update decidim-budgets/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-budgets/lib/decidim/budgets/project_serializer.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * reverted id and added budget title * extracted root_url helper for rspec test * extratced the budget url with test * translations updated for budget_url * extracted method to retrieve budget url * added test to get URL of budget * removed unused methods from spec * added title of budget * Improved the budget component serializer. id, url and title added to hash with test suite * updated i18n translations * Update decidim-budgets/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-budgets/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-budgets/lib/decidim/budgets/project_serializer.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-budgets/spec/serializers/project_serializer_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contract: 2024-flatfiles
Metagov grant
module: budgets
type: change
PRs that implement a change for an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Update of columns for the csv_export of the Projects component. This is a part of on going work in Ref: MGOV06
📌 Related Issues
Testing
run
decidim-budgets/spec/serializers/project_serializer_spec.rb
📷 Screenshots