Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profanity avatar names filtering #1508

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Profanity avatar names filtering #1508

merged 7 commits into from
Nov 15, 2021

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Nov 12, 2021

What does this PR change?

Adds profanity filtering to user names. So if a user's name contains an offensive word it should be filtered with ****:

  • General chat
  • Avatar name tags
  • Player info card (description is also filtered)

How to test the changes?

  1. Go to: https://play.decentraland.zone/?renderer-branch=feat/profanity-avatar-names-filtering
  2. Login with a friend who has an offensive name like "shithead". Also set a description with offensive words at the profile menu.
  3. Write anything on the general chat: your friend's name should be filtered ****head
  4. The avatar name tag should be filtered
  5. Open the profile info card by clicking on your friend's avatar. The name and description should be filtered

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@lorux0 lorux0 added the wip label Nov 12, 2021
@lorux0 lorux0 changed the title Feat/profanity avatar names filtering Profanity avatar names filtering Nov 12, 2021
@lorux0 lorux0 linked an issue Nov 12, 2021 that may be closed by this pull request
Apply profanity filtering to avatar names #1480
Closed
@lorux0 lorux0 force-pushed the feat/profanity-avatar-names-filtering branch from b55547d to b43f014 Compare November 12, 2021 18:06
AjimenezDCL
AjimenezDCL approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@AjimenezDCL AjimenezDCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I leave up to you whether to apply now the suggestion or leave it for when it's actually needed.

.../Assets/Scripts/MainScripts/DCL/Helpers/ProfanityFiltering/ProfanityFilterSharedInstances.cs Show resolved Hide resolved
@lorux0 lorux0 merged commit 09238fe into master Nov 15, 2021
@lorux0 lorux0 deleted the feat/profanity-avatar-names-filtering branch November 15, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AjimenezDCL AjimenezDCL AjimenezDCL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply profanity filtering to avatar names
2 participants
@lorux0 @AjimenezDCL