feat: Upgrade decentraland ui and dapps packages #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobarreto
approved these changes
Aug 4, 2023
| @@ -9,7 +9,7 @@ export const LinkedProfile = ({ isProfileEnabled, ...props }: Props) => { | |||
| const redirectionProps: RedirectionProps = isProfileEnabled | |||
| ? { | |||
| as: 'a', | |||
| href: `${profileUrl}/${address}` | |||
| href: `${profileUrl}${locations.account(address)}` | |||
There was a problem hiding this comment.
Suggested change
| href: `${profileUrl}${locations.account(address)}` | |
| href: `${profileUrl}/accounts/${address}` |
What do you think of hardcoding the path instead of using locations? I'm a bit concerned about the location function being for locations inside of the Marketplace. If we eventually change or delete the account path in the Marketplace, we'll be be changing the path to the profile url.
There was a problem hiding this comment.
good catch! let me update it
LautaroPetaccio
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the decentraland ui and dapps packages.
Old Menu style:
New Menu style:
