feat: insert suggestion comments in generated code #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward decaffeinate#1107 Rather than printing suggestions out to the console, I think it actually makes more sense to include them in the code. This should make them really hard to miss and be especially useful for the use case of doing a large conversion and then going through each file as a follow-up task. I added a `disableSuggestions` flag to disable this behavior if people want. For now, the `disableSuggestions` is always set to true from the CLI, meaning the feature can't be accessed normally now; it's just exposed to tests. I'll change it to false by default soon along with all of the other breaking changes.
eventualbuddha
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #1107
Rather than printing suggestions out to the console, I think it actually makes
more sense to include them in the code. This should make them really hard to
miss and be especially useful for the use case of doing a large conversion and
then going through each file as a follow-up task. I added a
disableSuggestionsflag to disable this behavior if people want.
For now, the
disableSuggestionsis always set to true from the CLI, meaningthe feature can't be accessed normally now; it's just exposed to tests. I'll
change it to false by default soon along with all of the other breaking changes.