Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor and auto spec cam in demo #9472

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix cursor and auto spec cam in demo #9472

merged 1 commit into from
Jan 3, 2025

Conversation

TsFreddie
Copy link
Contributor

Fixed two demo related issues.

  1. cursor doesn't work properl in follow mode if player's client id isn't 0
  2. auto zoom will instant snap in follow mode for recorded local player

Reference demos: (demo provided by always (@alw5) on discord
demos.zip

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

@def- def- added this to the DDNet 18.9 milestone Jan 3, 2025
@def- def- enabled auto-merge January 3, 2025 14:51
@def- def- added this pull request to the merge queue Jan 3, 2025
Merged via the queue into ddnet:master with commit 7df4613 Jan 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DDNet 18.9
Development

Successfully merging this pull request may close these issues.
2 participants
@TsFreddie @def-