Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data to Sv_TeamsState #9458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add data to Sv_TeamsState #9458

wants to merge 1 commit into from

Conversation

MilkeeyCat
Copy link
Contributor

Closes #8205

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

@MilkeeyCat MilkeeyCat force-pushed the pr_add_data_to_sv_teams_state branch from 3f81e35 to 2aa7442 Compare January 2, 2025 16:33
@ChillerDragon
Copy link
Contributor

Could also use MAX_CLIENTS instead of 64

@MilkeeyCat
Copy link
Contributor Author

Could also use MAX_CLIENTS instead of 64

What if the game would be built for 128 players?

@ChillerDragon
Copy link
Contributor

Aren't we planning to support 128 teams then? Or cap it at 64?

@MilkeeyCat
Copy link
Contributor Author

I thought Legacy in Sv_TeamsStateLegacy means it's old asf

@ChillerDragon
Copy link
Contributor

Fair. What about the non legacy one?

@MilkeeyCat
Copy link
Contributor Author

for those MAX_CLIENTS could be used, but maybe it could also work for legacy message, idk

@MilkeeyCat
Copy link
Contributor Author

@heinrich5991 should it be MAX_CLIENTS or 64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Net message SvTeamsState contains no data in network.py, should be an array of 64 ints
3 participants
@MilkeeyCat @ChillerDragon @def-