-
-
Notifications
You must be signed in to change notification settings - Fork 158
Conversation
I imagine you're already working on this, but please add a README.md with the full setup instructions, and an entry in the top-level README.md. Thanks! |
Added instructions that are hopefully understandable. |
You're awesome, I'll look forward to trying it out. I'm a never-ever with Blackfire. Should we/could we add at least a link to what you would do to try it out, how you'd know it was working? |
I'm unsure what would be needed. Basically after you followed the instructions (and added the client as described on the blackfire web page link) you should be able to start profiling requests either with the firefox or chrome addon or with the cli client as described here: https://blackfire.io/docs/cookbooks/profiling-http - does that help or do you need more info? if that's enough I can update the readme. if you need anything more, feel free to hit me up on TYPO3 slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches my setup and the one discussed in the main DDEV issues
@mglaman @susannemoog I worked through this as a Blackfire n00b and made a number of updates in 8dc1fb2 which I'd appreciate if you'd review. I'm not entirely convinced that we need the blackfire agent in a separate container, but whatever. Seems to me like we could just |
@rfay something weird seems to have happened in the And no, it's not strictly necessary to run the agent in a separate container, however it's cleaner and I think clearer that way, as in theory you'd need only one running agent for many projects connecting to it (and especially when thinking production setups and the like, making it clear that the agent is a separate service is nicer, I think). |
Something definitely happened, sorry! I'll fix. |
Fixed up basic usage in readme |
Looks better now. What about the firefox addon? Or do you deem it not important enough? It's fine either way from my side. |
Sorry, I just forgot. Feel free to push a commit in there. Thanks for the review and the pr! |
Thanks so much for this! |
No description provided.