Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Set option for collection type fields as well #135

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Aravind-MJ
Copy link

#134 - A possible fix to this issue. I've not tested all use cases but this solves my issue.

@Aravind-MJ Aravind-MJ requested a review from dcarbone as a code owner August 20, 2024 11:40
@Aravind-MJ
Copy link
Author

Aravind-MJ commented Aug 21, 2024

"title": "Eye Colour", is causing issue 😄
R4 doesn't have title for SearchParameter but R5 does.
This issue is not due to my changes 🍰

@dcarbone
Copy link
Owner

"title": "Eye Colour", is causing issue 😄

R4 doesn't have title for SearchParameter but R5 does.

This issue is not due to my changes 🍰

Yeah that's a known issue with the free R4 server I use. They have that extra field in there.

I think this lgtm! Will cut a release in a little bit.

@dcarbone dcarbone merged commit 9112e10 into dcarbone:main Aug 21, 2024
17 of 20 checks passed
@dcarbone dcarbone added this to the v3.0.7 milestone Aug 22, 2024
@dcarbone dcarbone self-assigned this Aug 22, 2024
@dcarbone dcarbone linked an issue Aug 22, 2024 that may be closed by this pull request
@dcarbone dcarbone modified the milestones: v3.0.7, v3.1.0 Aug 22, 2024
@Aravind-MJ Aravind-MJ deleted the aravind/set-for-collections branch August 22, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to set or clear an array field
2 participants