Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong match for "C:\name.ext" to glob pattern "C:\name\**" #29

Closed
czjlorenz opened this issue Jun 30, 2017 · 4 comments
Closed

wrong match for "C:\name.ext" to glob pattern "C:\name\**" #29

czjlorenz opened this issue Jun 30, 2017 · 4 comments
Assignees
@dazinator
Labels
bug

Comments

@czjlorenz
Copy link

given the following test code ...

var glob = DotNet.Globbing.Glob.Parse( @"C:\name\**" );
bool result = glob.IsMatch( @"C:\name.ext" );
result = glob.IsMatch( @"C:\name_longer.ext" );`

... the result of IsMatch() is true in both cases. To my mind this is wrong. The result should be false. I am using DotNet.Glob-1.6.1 from nuget.org.
@dazinator
Copy link
Owner

Thanks for finding this. I'll add test coverage for this case and get back to you!

@dazinator dazinator self-assigned this Jun 30, 2017
@dazinator dazinator added the bug label Jun 30, 2017
@dazinator
Copy link
Owner

Verified.

@dazinator
Copy link
Owner

dazinator commented Jun 30, 2017 •
edited
Loading

Hotfix pushed. Once appveyor builds and publishes (takes a few minutes) version 1.6.2 will appear on nuget - upgrade to that for the fix.

Thank you for reporting.

@dazinator
Copy link
Owner

dazinator commented Jun 30, 2017 •
edited
Loading

  • FYI, it turned out to be 1.6.3 that has been published to nuget in the end - I had a build error in my cake script that needed to also be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dazinator dazinator

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dazinator @czjlorenz