Add monochrome icon for material you theming #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The By adding the same 
|
|
Awesome! Thank you so much, and obvious in hindsight. Should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to add support for android themed icons supported in Android 13+ (if you are interested). I thought it would be a quick addition of a monochrome version of the foreground drawable, however this doesn't seem to be the complete fix, at least on my emulator.
It may have something to do with
Theme.AppCompat, however I am not sure. Putting this up as a draft in case anyone else knows of a quick fix to get it the rest of the way there. I'll come back and work on it some more when I have time.Docs: https://developer.android.com/develop/ui/views/launch/icon_design_adaptive