Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/avoid changing unrelated parent elements #400

Conversation

kayhadrin
Copy link
Contributor

Use jQuery .closest() instead of .parents() because the latter will also reach parent elements of the plugin container

In other words, if the multiselect plugin is used inside a LI tag, it will eventually modify (e.g. adding the .active css class) it which is not intended.

…ch parent elements of the plugin container

In other words, if the multiselect plugin is used inside an LI.container tag, it will eventually modify it which is not intended
@kayhadrin kayhadrin changed the title Fix/avoid changing unrelatd parent elements Fix/avoid changing unrelated parent elements Oct 9, 2014
@davidstutz davidstutz added the bug label Oct 13, 2014
@davidstutz
Copy link
Owner

Thanks!

davidstutz added a commit that referenced this pull request Oct 13, 2014
…rent-elements

#375, #383: Avoid changing unrelated parent elements.
@davidstutz davidstutz merged commit ddd2fe8 into davidstutz:master Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants