Allow multiple QR code instances #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes davidshimjs#2 Previously, private variables were trapped by the outer function closure that returns the Drawing constructor. I removed these declarations and scoped them to the object instance. This has the side affect of making them public. If that is undesirable, the code can be refactored further to keep these private. I haven't fully tested all codepaths (table based drawing, android specific logic), so more regression should probably be done before merging this in to your codebase.
In _safeSetDataURI forgot to save off reference to this so callbacks could keep a reference to the original this.
This reverts commit 95b47b9.
Had forgotten to save of reference to this so that callbacks would have a reference to the original instance.
davidshimjs
added a commit
that referenced
this pull request
Jun 3, 2013
It works. Thank you @davidcl64
davidshimjs
pushed a commit
that referenced
this pull request
Jun 3, 2013
wing-kai
pushed a commit
to shenhudong/qrcodejs
that referenced
this pull request
May 11, 2019
Fix compatibility with webpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Previously, private variables were trapped by the outer function
closure that returns the Drawing constructor.
I removed these declarations and scoped them to the object instance.
This has the side affect of making them public. If that is
undesirable, the code can be refactored further to keep these private.
I haven't fully tested all codepaths (table based drawing, android
specific logic), so more regression should probably be done before
merging this in to your codebase.