Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated it locale for version 2.0 #855

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Updated it locale for version 2.0 #855

merged 3 commits into from
Sep 18, 2018

Conversation

vin-car
Copy link
Member

@vin-car vin-car commented Sep 3, 2018

Updated the italian [it] locale to make it work with v2.

kossnocorp
kossnocorp approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good to me. Waiting for @leshakoss approval.

@vin-car could you please:

@vin-car
Copy link
Member Author

vin-car commented Sep 12, 2018

Thanks @kossnocorp for the good feedback on code.
As requested, I've removed it from outdatedLocales.json, while I had already mentioned myself in the author section of https://github.com/vin-car/date-fns/blob/it-locale-for-2.0/src/locale/it/index.js

Let me know if there is something else I missed to progress this PR, I'm happy to contribute.

@kossnocorp
Copy link
Member

@vin-car all good, thank you for the PR 🤗 I'm going to release it as soon as possible.

@kossnocorp kossnocorp mentioned this pull request Sep 18, 2018
Merged
leshakoss
leshakoss approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kossnocorp kossnocorp merged commit 973d137 into date-fns:master Sep 18, 2018
@kossnocorp
Copy link
Member

I've just published a new version with this locale date-fns@2.0.0-alpha.18. See the change log: https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136#v200-alpha18

Thank you again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leshakoss leshakoss leshakoss approved these changes

@kossnocorp kossnocorp kossnocorp approved these changes

Assignees
No one assigned
Labels
🌏 I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vin-car @kossnocorp @leshakoss