Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(system): add build options table #9502

Merged
merged 4 commits into from
Jan 8, 2023
Merged

feat(system): add build options table #9502

merged 4 commits into from
Jan 8, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jan 7, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

MySQL [(none)]> select * from system.build_options;
+------------------------+---------+
| available_features     | enabled |
+------------------------+---------+
| default                |       1 |
| io-uring               |       0 |
| thrift                 |       0 |
| hive                   |       0 |
| memory-profiling       |       0 |
| tokio-console          |       0 |
| simd                   |       1 |
| common-hive-meta-store |       0 |
| common-storages-hive   |       0 |
| storage-hdfs           |       0 |
| tempfile               |       0 |
+------------------------+---------+
11 rows in set (0.032 sec)

Closes #issue

@vercel
Copy link

vercel bot commented Jan 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 8, 2023 at 0:25AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 7, 2023
@PsiACE
Copy link
Member Author

PsiACE commented Jan 7, 2023 •
edited
Loading

A basic impl for #9495 . Feel free to comment.

There are a number of warnings caused by chrono that need to be fixed.

@PsiACE
Copy link
Member Author

PsiACE commented Jan 7, 2023

cc @sundy-li , what other information do we need to add?

@sundy-li
Copy link
Member

sundy-li commented Jan 7, 2023

Seems it's rust cargo features, can we have target features?

We release binary as RUSTFLAGS="-C target-feature=+sse4.2" cargo build --bin databend-query --release

@PsiACE

This comment was marked as outdated.

Sign in to view
@PsiACE
Copy link
Member Author

PsiACE commented Jan 7, 2023

cargo-features for enabled features (in Cargo.toml), target-fetures for CARGO_CFG_TARGET_FEATURE.

MySQL [(none)]> select * from system.build_options;
+----------------+---------------------+
| cargo_features | target_features     |
+----------------+---------------------+
| default        | fxsr                |
| simd           | llvm14-builtins-abi |
|                | sse                 |
|                | sse2                |
+----------------+---------------------+
4 rows in set (0.032 sec)

@PsiACE PsiACE marked this pull request as ready for review January 7, 2023 18:35
@BohuTANG BohuTANG requested a review from sundy-li January 8, 2023 00:01
@BohuTANG
Copy link
Member

BohuTANG commented Jan 8, 2023

build_aarch64_musl failed:

error: environment variable `VERGEN_CARGO_FEATURES` not defined
  --> src/query/service/src/databases/system/build_options_table.rs:45:48
   |
45 |         let mut cargo_features: Vec<Vec<u8>> = env!("VERGEN_CARGO_FEATURES")
   |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: ignoring -C extra-filename flag due to -o flag

@PsiACE
Copy link
Member Author

PsiACE commented Jan 8, 2023

build_aarch64_musl failed:

This has been fixed in the latest commit.

@BohuTANG BohuTANG merged commit c29190e into databendlabs:main Jan 8, 2023
@PsiACE PsiACE mentioned this pull request Jan 8, 2023
Closed
@PsiACE PsiACE deleted the build-options branch January 9, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PsiACE @sundy-li @BohuTANG