Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataform server boilerplate #601

Merged
merged 10 commits into from
Feb 11, 2020
Merged

Dataform server boilerplate #601

merged 10 commits into from
Feb 11, 2020

Conversation

lewish
Copy link
Collaborator

@lewish lewish commented Feb 10, 2020

This introduces the bazel set up for us to start a server. It doesn't actually do anything interesting, but get's everything in place for future development.

  • Adds rules for protobufjs ts service code generation, copied from closed-source
  • Adds a grpc-web rpc_impl for protobufjs, also from closed source
  • Adds bazel webpack rules, dependencies and a minimal starter impl for the UI
  • Adds a boilerplate grpc-service impl for the backend
  • Serves an HTTP server via express, grpc server, and grpc-web-proxy from a single node binary

Can be run with:

bazel run server:bin --project-dir <path-to-some-dataform-project>

@lewish lewish requested a review from faiyaz26 February 10, 2020 16:02
faiyaz26
faiyaz26 approved these changes Feb 10, 2020
View reviewed changes
app/service.ts
private static instance: Service;

constructor() {
super(rpcImpl("http://localhost:9111", "dataform.server.Service"), false, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this port be configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately without some template/variable solution, this is hard to do :/

protos/server.proto Outdated Show resolved Hide resolved
@lewish lewish merged commit f3085c3 into master Feb 11, 2020
@lewish lewish deleted the dataform_server_boilerplate branch February 11, 2020 10:07
kolina pushed a commit that referenced this pull request Feb 15, 2023
@lewish
Dataform server boilerplate (#601)
c72321a 
* Dataform UI app & server boilerplate

* Remove storybook

* Update yargs

* Revert yargs upgrade

* Fix some types

* Fix tag

* Revert accidental change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faiyaz26 faiyaz26 faiyaz26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewish @faiyaz26