Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(binder): fix bind cte #17183

Merged
merged 7 commits into from
Jan 7, 2025
Merged

bug(binder): fix bind cte #17183

merged 7 commits into from
Jan 7, 2025

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Jan 6, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Close: #17181

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 6, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Jan 6, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Jan 6, 2025
@Dousir9 Dousir9 marked this pull request as ready for review January 7, 2025 00:54
@Dousir9 Dousir9 enabled auto-merge January 7, 2025 00:54
@Dousir9 Dousir9 added this pull request to the merge queue Jan 7, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 7, 2025
@BohuTANG BohuTANG merged commit f175270 into databendlabs:main Jan 7, 2025
75 checks passed
everpcpc pushed a commit that referenced this pull request Jan 7, 2025
@Dousir9 @everpcpc
chore(binder): fix bind cte (#17183)
53fdc37 
* chore(binder): fix bind cte

* chore(test): add sqllogictest

* chore(binder): refine code

* chore(binder): remove materialized cte in create table stmt with

* chore(binder): fix m_cte_to_temp_table

* chore(code): refine code

* chore(code): refine code
everpcpc pushed a commit to everpcpc/databend that referenced this pull request Jan 7, 2025
@Dousir9 @everpcpc
chore(binder): fix bind cte (databendlabs#17183)
c2402bd 
* chore(binder): fix bind cte

* chore(test): add sqllogictest

* chore(binder): refine code

* chore(binder): remove materialized cte in create table stmt with

* chore(binder): fix m_cte_to_temp_table

* chore(code): refine code

* chore(code): refine code
@BohuTANG BohuTANG added the C-bug Category: something isn't working label Jan 7, 2025
@BohuTANG BohuTANG changed the title chore(binder): fix bind cte bug(binder): fix bind cte Jan 7, 2025
@BohuTANG BohuTANG removed the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request's title is not fulfill the requirements. @Dousir9 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

everpcpc added a commit that referenced this pull request Jan 7, 2025
@everpcpc @Dousir9 @zhyass
chore(binder): fix bind cte (#17187)
2ae7380 
* chore(binder): fix bind cte (#17183)

* fix(ci): flaky test (#17149)

---------

Co-authored-by: Jk Xu <54522439+Dousir9@users.noreply.github.com>
Co-authored-by: zhya <mytesla@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
C-bug Category: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTE bug: table not found
3 participants
@Dousir9 @sundy-li @BohuTANG