Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add built-in udfs in config #15938

Merged
merged 9 commits into from
Jul 2, 2024
Merged

feat: add built-in udfs in config #15938

merged 9 commits into from
Jul 2, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jul 1, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR:

  • spill out IDM config type conversion from the config crate, make the config only define as string
  • UserConfig to meta UserAuthInfo convert in builtin/builtin_user.rs
  • UDFConfig to meta UserDefinedFunction convert in builtin/builtin_udf.rs

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jul 1, 2024
@BohuTANG BohuTANG force-pushed the dev-builtin-udfs branch from 4a28b62 to e059f9c Compare July 2, 2024 02:56
@BohuTANG BohuTANG changed the title chore: spill out built-in users and udfs chore: add built-in udfs in config Jul 2, 2024
@BohuTANG BohuTANG changed the title chore: add built-in udfs in config feat: add built-in udfs in config Jul 2, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 2, 2024
@BohuTANG BohuTANG force-pushed the dev-builtin-udfs branch from 52e4bef to 87474bc Compare July 2, 2024 05:12
@BohuTANG BohuTANG marked this pull request as ready for review July 2, 2024 05:24
@BohuTANG BohuTANG requested review from youngsofun and everpcpc July 2, 2024 05:24
@BohuTANG
Copy link
Member Author

BohuTANG commented Jul 2, 2024

Will fix the failed test later.

@BohuTANG BohuTANG force-pushed the dev-builtin-udfs branch from 701bfd1 to 7537952 Compare July 2, 2024 11:04
@youngsofun
Copy link
Member

youngsofun commented Jul 2, 2024 •
edited
Loading

what about predefined or preconfigured? built-in sounds like hard-coded in code?

@BohuTANG
Copy link
Member Author

BohuTANG commented Jul 2, 2024

what about predefined or preconfigured? built-in sounds like hard-coded in code?

This PR make the the built-in users/udfs configured in the config file not code, built-in is make sense I think.

@BohuTANG BohuTANG requested review from everpcpc and youngsofun July 2, 2024 12:15
@BohuTANG
Copy link
Member Author

BohuTANG commented Jul 2, 2024

The unit-test failed not releated to this PR:

--- STDOUT:              databend-common-meta-api txn_backoff::tests::test_backoff ---

running 1 test
test txn_backoff::tests::test_backoff ... FAILED

failures:

failures:
    txn_backoff::tests::test_backoff

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 0.19s


--- STDERR:              databend-common-meta-api txn_backoff::tests::test_backoff ---
thread 'txn_backoff::tests::test_backoff' panicked at src/meta/api/src/txn_backoff.rs:156:9:
0.088934727 is expected to be 2 + 5 + 10 + 14 + 20 milliseconds
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@BohuTANG
Copy link
Member Author

BohuTANG commented Jul 2, 2024

Will merge for bendml with the torrmow release. Any suggestions also welcome.

@BohuTANG BohuTANG merged commit 38c157b into databendlabs:main Jul 2, 2024
70 of 72 checks passed
@BohuTANG BohuTANG mentioned this pull request Jul 8, 2024
Closed
@TCeason TCeason mentioned this pull request Jul 8, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everpcpc everpcpc Awaiting requested review from everpcpc

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BohuTANG @youngsofun @everpcpc