remove conf from RpcService by using session_mgr's conf
#1305
Conversation
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
| @@ -60,6 +60,10 @@ impl SessionManager { | |||
| })) | |||
| } | |||
|
|
|||
| pub fn get_conf(&self) -> &Config { | |||
There was a problem hiding this comment.
If we want to return ref of Config, maybe get_conf -> get_conf_ref is better?
There was a problem hiding this comment.
I am not sure...
Since there are DataSchemaRef, SessionManagerRef ..., it seems that if ref is explicitly mentioned, it means Arc<Something>.
But I am Ok with it, if get_conf_ref is preferred, I'd like to rename it.
There was a problem hiding this comment.
Bad name ideas from arrow, type ArrayRef = Arc;
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
======================================
- Coverage 72% 72% -1%
======================================
Files 478 478
Lines 27843 27863 +20
======================================
+ Hits 20170 20175 +5
- Misses 7673 7688 +15
Continue to review full report at Codecov.
|
|
Hello @dantengsky, 🎉 Thank you for opening the pull request! 🎉 |
|
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Summary about this PR
Changelog
Related Issues
Fixes #1304
Test Plan
Unit Tests
Stateless Tests