Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafuse CLI] e2e framework for fusecli #1299

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[Datafuse CLI] e2e framework for fusecli #1299

merged 1 commit into from
Aug 5, 2021
+47 −0

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Aug 5, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Introduce BDD driven test framework for fusecli, using abseil test and asyncio as implementation

Changelog

  • New Feature

Related Issues

fixes #1298

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 5, 2021
@databend-bot
Copy link
Member

Hello @ZhiHanZ, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

BohuTANG
BohuTANG approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #1299 (4e34d24) into master (add8ecd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1299   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         475     475           
  Lines       27558   27558           
======================================
  Hits        19907   19907           
  Misses       7651    7651

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add8ecd...4e34d24. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit be787d2 into master Aug 5, 2021
@databend-bot databend-bot deleted the fusecli-e2e branch August 5, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cli] Introduce E2E test for cli interface
4 participants
@ZhiHanZ @databend-bot @codecov-commenter @BohuTANG