Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] performance test api rfc #1291

Merged
merged 2 commits into from
Aug 5, 2021
Merged

[Doc] performance test api rfc #1291

merged 2 commits into from
Aug 5, 2021

Conversation

ZhiHanZ
Copy link
Collaborator

@ZhiHanZ ZhiHanZ commented Aug 4, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Update documentation and test on performance tests

Changelog

  • Documentation
  • Website

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@ZhiHanZ ZhiHanZ marked this pull request as draft August 4, 2021 15:48
@databend-bot
Copy link
Member

Hello @ZhiHanZ, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Aug 4, 2021

/run-perf master

@databend-bot
Copy link
Member

run performance on sha 1445760 reference on master

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021 •
edited
Loading

Codecov Report

Merging #1291 (a141ddf) into master (ed3373f) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1291   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         479     479           
  Lines       29233   29233           
======================================
+ Hits        21198   21199    +1     
+ Misses       8035    8034    -1
Impacted Files Coverage Δ
...pelines/transforms/transform_aggregator_partial.rs 89% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3373f...a141ddf. Read the comment docs.

@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Aug 4, 2021

/run-perf master

@databend-bot
Copy link
Member

run performance on sha a141ddf reference on master

@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Aug 5, 2021

/run-perf master

@databend-bot
Copy link
Member

run performance on sha a141ddf reference on master

@ZhiHanZ
Copy link
Collaborator Author

ZhiHanZ commented Aug 5, 2021

/run-perf master

@databend-bot
Copy link
Member

run performance on sha a141ddf reference on master

@ZhiHanZ ZhiHanZ marked this pull request as ready for review August 5, 2021 06:41
@ZhiHanZ ZhiHanZ requested a review from BohuTANG August 5, 2021 06:46
BohuTANG
BohuTANG approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @ZhiHanZ

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit bff4021 into master Aug 5, 2021
@databend-bot databend-bot deleted the perf branch August 5, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhiHanZ @databend-bot @codecov-commenter @BohuTANG