Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support more than two predicates for iejoin #11584

Merged
merged 3 commits into from
May 26, 2023
Merged

feat: support more than two predicates for iejoin #11584

merged 3 commits into from
May 26, 2023

Conversation

xudong963
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support more than two predicates for iejoin, such as

SELECT s1.rid, s2.rid
FROM west s1, west s2
WHERE s1.time > s2.time AND s1.cost < s2.cost AND s1.rid > s2.rid;

Predicates with more than two are placed in other_conditions

Closes #issue

@vercel
Copy link

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) May 26, 2023 3:36am

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 25, 2023
@xudong963 xudong963 requested review from leiysky and Dousir9 May 25, 2023 08:17
@xudong963 xudong963 merged commit 7cfe964 into databendlabs:main May 26, 2023
@xudong963 xudong963 deleted the other_condition branch May 26, 2023 07:15
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@xudong963 @andylokandy
feat: support more than two predicates for iejoin (databendlabs#11584)
1a51474 
* feat: support more than two predicates for iejoin

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xudong963 @Dousir9