Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add escape for management key #3792

Closed
Tracked by #3428
BohuTANG opened this issue Jan 6, 2022 · 4 comments
Closed
Tracked by #3428

Add escape for management key #3792

BohuTANG opened this issue Jan 6, 2022 · 4 comments
Assignees
@zenmiao7
Labels
C-improvement Category: improvement community-take good first issue Category: good first issue

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Jan 6, 2022

Summary

Cluster already has the escape for the key:
https://github.com/datafuselabs/databend/blob/b80c460048cbf64eb4dd2f5c7d905df4fc9b677f/common/management/src/cluster/cluster_mgr.rs#L62-L83

stage/udf/user also need.
@BohuTANG BohuTANG added C-improvement Category: improvement good first issue Category: good first issue labels Jan 6, 2022
@zenmiao7
Copy link
Contributor

zenmiao7 commented Feb 6, 2022

/assignme

@BohuTANG BohuTANG mentioned this issue Mar 5, 2022
Closed
29 tasks
@BohuTANG
Copy link
Member Author

BohuTANG commented Mar 5, 2022

Hello, @Blacksmith96
Any progress for this issue? We add this issue to v0.7(plan to release in the mid of this month).
Thanks.

@zenmiao7
Copy link
Contributor

zenmiao7 commented Mar 6, 2022

@BohuTANG Sorry for delay. I'll create a PR these two days.

@BohuTANG
Copy link
Member Author

BohuTANG commented Mar 6, 2022

Thank you.

@zenmiao7 zenmiao7 mentioned this issue Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenmiao7 zenmiao7

Labels
C-improvement Category: improvement community-take good first issue Category: good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BohuTANG @zenmiao7 @databend-bot