Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy DataFrame implementation #8968

Merged
merged 17 commits into from
Dec 20, 2024
Merged

Remove legacy DataFrame implementation #8968

merged 17 commits into from
Dec 20, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Dec 17, 2024 •
edited
Loading

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

sibling of dask/dask#11606

@phofl phofl requested a review from fjetter as a code owner December 17, 2024 12:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files   -     2      27 suites   - 2   11h 37m 53s ⏱️ - 38m 6s
 4 127 tests  -     3   4 013 ✅  -     1    112 💤 +  1  2 ❌  - 2 
51 714 runs   - 4 126  49 409 ✅  - 3 997  2 300 💤  - 127  5 ❌  - 1 

For more details on these failures, see this check.

Results for commit 8651e41. ± Comparison against base commit 922888e.

This pull request removes 3 tests. 
distributed.shuffle.tests.test_graph ‑ test_basic
distributed.shuffle.tests.test_merge ‑ test_minimal_version
distributed.shuffle.tests.test_shuffle ‑ test_minimal_version
This pull request skips 1 test. 
distributed.shuffle.tests.test_shuffle ‑ test_restrictions

♻️ This comment has been updated with latest results.

hendrikmakait
hendrikmakait approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl. LGM as long as CI is green.

continuous_integration/environment-3.10.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-3.11.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-3.12.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-3.13.yaml Outdated Show resolved Hide resolved
continuous_integration/environment-mindeps.yaml Outdated Show resolved Hide resolved
@phofl phofl merged commit 8005dec into dask:main Dec 20, 2024
22 of 30 checks passed
@phofl phofl deleted the remove-legacy-implementation branch December 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @hendrikmakait