Remove subgraph callable #8956
Merged
Remove subgraph callable #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Dec 3, 2024
.pre-commit-config.yaml
Outdated
| @@ -64,7 +64,7 @@ repos: | |||
| - tornado | |||
| - pyarrow | |||
| - urllib3 | |||
| - git+https://github.com/dask/dask | |||
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 11h 35m 10s ⏱️ + 4m 31s For more details on these failures, see this check. Results for commit 07cb6cd. ± Comparison against base commit 7f14edf. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
fjetter
force-pushed
the
remove_subgraph_callable
branch
2 times, most recently
from
6a53e35 to
f333a4e
Compare
|
Remaining CI failures should be #8978 |
fjetter
force-pushed
the
remove_subgraph_callable
branch
from
efc05f1 to
07cb6cd
Compare
fjetter
force-pushed
the
remove_subgraph_callable
branch
from
07cb6cd to
ba5b65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dask/dask#11568 the SubgraphCallable is now effectively dead code. There is just one exception since the optimization
optimization.fuse.subgraphsis on by default for the legacy dataframe.Sibling in dask/dask dask/dask#11575