Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value_counts shuffling strategy #11698

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix value_counts shuffling strategy #11698

merged 1 commit into from
Jan 24, 2025

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Jan 24, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ± 0       15 suites  ±0   4h 25m 56s ⏱️ + 5m 51s
 17 142 tests + 1   15 962 ✅ + 1   1 180 💤 ±0  0 ❌ ±0 
211 224 runs  +12  194 201 ✅ +14  17 023 💤  - 2  0 ❌ ±0 

Results for commit 9fccdaa. ± Comparison against base commit d8eb38e.

hendrikmakait
hendrikmakait approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl!

@hendrikmakait hendrikmakait merged commit 39b918f into dask:main Jan 24, 2025
25 of 27 checks passed
@phofl phofl deleted the value_counts branch January 24, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.value_counts() failed to aggregate across partitions
2 participants
@phofl @hendrikmakait