Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the shuffle algorithm for take #11267

Merged
merged 26 commits into from
Aug 5, 2024
Merged

Use the shuffle algorithm for take #11267

merged 26 commits into from
Aug 5, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Aug 1, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@phofl phofl marked this pull request as draft August 1, 2024 14:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ± 0       15 suites  ±0   3h 26m 22s ⏱️ - 4m 38s
 13 137 tests  -  3   12 069 ✅  -  3   1 068 💤 ±0  0 ❌ ±0 
162 899 runs   - 39  140 111 ✅  - 39  22 788 💤 ±0  0 ❌ ±0 

Results for commit 7d8c08b. ± Comparison against base commit 8fa8d2e.

This pull request removes 3 tests. 
dask.array.tests.test_slicing ‑ test_slicing_plan[chunks0-index0-expected0]
dask.array.tests.test_slicing ‑ test_slicing_plan[chunks1-index1-expected1]
dask.array.tests.test_slicing ‑ test_slicing_plan[chunks2-index2-expected2]

♻️ This comment has been updated with latest results.

@phofl phofl mentioned this pull request Aug 1, 2024
Merged
3 tasks
@phofl phofl mentioned this pull request Aug 5, 2024
Open
@phofl
Merge remote-tracking branch 'refs/remotes/upstream/main' into array-…
848a319 
…shuffle-for-take

# Conflicts:
#	dask/array/_shuffle.py
#	dask/array/core.py
#	dask/array/tests/test_shuffle.py
#	dask/dask-schema.yaml
@phofl phofl changed the title Hook shuffle into take Use the shuffle algorithm for take Aug 5, 2024
@phofl phofl marked this pull request as ready for review August 5, 2024 15:51
hendrikmakait
hendrikmakait approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI ends up being happy. Thanks, @phofl!

@phofl phofl mentioned this pull request Aug 5, 2024
Closed
4 tasks
@phofl phofl merged commit 1587b3b into dask:main Aug 5, 2024
26 of 27 checks passed
@phofl phofl deleted the array-shuffle-for-take branch August 5, 2024 18:35
@rjzamora rjzamora mentioned this pull request Aug 14, 2024
Open
@davidhassell davidhassell mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @hendrikmakait