Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set CCACHE_SIZE to 400M for Gitlab #5547

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Aug 24, 2023

Issue being fixed or feature implemented

Make CI builds faster.

We have this https://github.com/dashpay/dash/blob/develop/ci/dash/build_src.sh#L18 but by that time CCACHE_SIZE is set to 100M via https://github.com/dashpay/dash/blob/develop/ci/test/00_setup_env.sh#L51 already.

What was done?

set CCACHE_SIZE variable in .gitlab-ci.yml, drop confusing and useless lines from ci/dash/build_src.sh (CCACHE_SIZE and CCACHE_COMPRESS defaults are handled by ci/test/00_setup_env.sh)

How Has This Been Tested?

I set CCACHE_SIZE to 400M yesterday via Gitlab UI to test it.

results:
before, trivial doc change, 100M: https://gitlab.com/dashpay/dash/-/jobs/4931233566#L59 (~17 minutes)
after, trivial code change, 400M: https://gitlab.com/dashpay/dash/-/jobs/4935764148#L80 (~12 minutes)

Removed it from Gitlab UI now but it should still say Set cache size limit to 400.0 MB in logs for this PR.

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Aug 24, 2023
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 8c4fb2a into dashpay:develop Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants