fix(ci): only run jobs when their ancestors on prevoius stages succeeded #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
Jun 5, 2023
UdjinM6
force-pushed
the
ci_require_success
branch
from
9ebbc57 to
8117721
Compare
PastaPastaPasta
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We should not be running jobs if their ancestors failed. This was broken with the introduction of
FAST_MODE/.skip-in-fast-mode-templateI think (via #3635).What was done?
Adjust ci rules, make them explicit.
How Has This Been Tested?
Compare
teststages:https://gitlab.com/dashpay/dash/-/pipelines/888510672 (note: some of
teststage jobs were started, even though all related jobs frombuildstage have failed)vs
https://gitlab.com/UdjinM6/dash/-/pipelines/888923382 (note: none of
teststage jobs were started)Breaking Changes
n/a
Checklist: