fix(ci): skip more jobs in "FAST_MODE" #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
Apr 11, 2023
| extends: .build-template | ||
| extends: | ||
| - .build-template | ||
| - .skip-in-fast-mode-template |
There was a problem hiding this comment.
I think fuzz build is important for fast mode because usually it catches high percentage of all failures.
There is almost hundred of C++ source and any changes in class/structure interfaces, any noticeable big refactoring or big changes almost always cause a fail during fuzz build.
I vote for keeping linux64_fuzz-build in fast-mode
There was a problem hiding this comment.
hmmm... but we don't really run src/test/fuzz/fuzz anywhere as far as I can tell, we just compile it
There was a problem hiding this comment.
just on this week PRs that failed for fuzz related code (compile, not run!):
- backport: trivial backports 2023 04 09 #5310 - https://gitlab.com/dashpay/dash/-/jobs/4087550129
- backport: merge bitcoin#19192, #18968, #19191, #18991, #19658, #19697, #20000, #19638, #20120, #20757, #20965, #20284, #22025, #22179 (auxiliary backports: part 10) #5306 - https://gitlab.com/dashpay/dash/-/pipelines/832877324
knst
approved these changes
Apr 13, 2023
PastaPastaPasta
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
CI should not be running that many jobs in "FAST_MODE"
https://github.com/dashpay/dash/blob/develop/.gitlab-ci.yml#L5
What was done?
assign
.skip-in-fast-mode-templatetemplate to more jobsHow Has This Been Tested?
ran CI in my repo
before: https://gitlab.com/UdjinM6/dash/-/pipelines/832175740
after: https://gitlab.com/UdjinM6/dash/-/pipelines/832176325
Breaking Changes
n/a
Checklist:
For repository code-owners and collaborators only