Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): disable --tls for docker explicitly #5068

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix(ci): disable --tls for docker explicitly #5068

merged 1 commit into from
Oct 31, 2022

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Oct 30, 2022 •
edited
Loading

Issue being fixed or feature implemented

disable --tlsverify for docker explicitly to avoid warnings/errors in builder-image job

includes #5045 to check if dashpay's gitlab-runner is configured correctly (it uses docker+machine unlike the pure docker I personally use)

What was done?

see https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27300#note_621025442 for more info

How Has This Been Tested?

CI:
docker+machine: https://gitlab.com/dashpay/dash/-/pipelines/681001913
docker: https://gitlab.com/UdjinM6/dash/-/pipelines/681001733

CI with #5045 included:
docker+machine: https://gitlab.com/dashpay/dash/-/pipelines/680993065
docker: https://gitlab.com/UdjinM6/dash/-/pipelines/680993031

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@UdjinM6 UdjinM6 added this to the 18.2 milestone Oct 30, 2022
@UdjinM6 UdjinM6 force-pushed the pr5045 branch 2 times, most recently from 56e8f8d to 65d6ba1 Compare October 31, 2022 00:52
@UdjinM6 UdjinM6 changed the title fix: update .gitlab-ci.yml to enable --tlsverify fix(ci): disable --tls for docker explicitly Oct 31, 2022
@UdjinM6 UdjinM6 marked this pull request as ready for review October 31, 2022 01:18
PastaPastaPasta
PastaPastaPasta approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 8b37fd6 into dashpay:develop Oct 31, 2022
@UdjinM6 UdjinM6 deleted the pr5045 branch November 27, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.2
Development

Successfully merging this pull request may close these issues.
2 participants
@UdjinM6 @PastaPastaPasta