Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge #16404: qa: Test ZMQ notification after chain reorg" #4646

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 30, 2021

16404 backported via #4610 broke zmq test and it's annoying to have CI fail all the time. I can't find any way to fix it (related backports aren't linear it seems and partial fixes I picked did not help). Proposing to revert it for now. If anyone has a better idea how to fix CI, I'll gladly close this one :)

@UdjinM6 UdjinM6 added this to the 18 milestone Dec 30, 2021
@PastaPastaPasta
Copy link
Member

conflicts with #4642 (investigating action failure)

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge (even though this will break my backport script...)

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit db312c3 into dashpay:develop Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants