Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable experimental Cxx20 support #4600

Merged
merged 5 commits into from
Dec 11, 2021

Conversation

PastaPastaPasta
Copy link
Member

No description provided.

@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Dec 1, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a ci job with --enable-c++20. Let's maybe "upgrade" linux64_cxx17?

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

This pull request has conflicts, please rebase.

@@ -59,10 +59,10 @@ elif [ "$BUILD_TARGET" = "linux64" ]; then
export BITCOIN_CONFIG="--enable-zmq --enable-reduce-exports --enable-crash-hooks --with-sanitizers=undefined"
export CPPFLAGS="-DDEBUG_LOCKORDER -DENABLE_DASH_DEBUG -DARENA_DEBUG"
export PYZMQ=true
elif [ "$BUILD_TARGET" = "linux64_cxx17" ]; then
elif [ "$BUILD_TARGET" = "linux64_cxx20" ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also tweak .gitlab-ci.yml

Signed-off-by: pasta <pasta@dashboost.org>
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 683be40 into dashpay:develop Dec 11, 2021
@PastaPastaPasta PastaPastaPasta deleted the cxx20 branch December 11, 2021 23:14
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 17, 2022
* build: Add optional c++20 compilation option

* build: update ax_cxx_compile_stdcxx.m4 to be compatible with c++20

* fix: fix c++20 build error for undefined identifier

* ci: enable c++20 build during ci

* cxx17 -> cxx20

Signed-off-by: pasta <pasta@dashboost.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants