Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Change Node Type to recognize 3 types: Regular, Masternode and Verified Masternode #3995

Merged
merged 1 commit into from
Feb 11, 2021
Merged

qt: Change Node Type to recognize 3 types: Regular, Masternode and Verified Masternode #3995

merged 1 commit into from
Feb 11, 2021

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 11, 2021

No description provided.

@UdjinM6 UdjinM6 added this to the 17 milestone Feb 11, 2021
@UdjinM6 UdjinM6 marked this pull request as ready for review February 11, 2021 11:57
xdustinface
xdustinface approved these changes Feb 11, 2021
View reviewed changes
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

thephez
thephez approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Slightly tested ACK. This is a good improvement imo. Can always tell who is a MN plus the Verified status gives a bit more info on top of that.

PastaPastaPasta
PastaPastaPasta approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 5ce5e35 into dashpay:develop Feb 11, 2021
@UdjinM6 UdjinM6 deleted the 3_node_types branch July 1, 2021 21:58
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Apr 16, 2022
@UdjinM6 @gades
qt: Change Node Type to recognize 3 types: Regular, Masternode and Ve…
5002af0 
…rified Masternode (dashpay#3995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdustinface xdustinface xdustinface approved these changes

@thephez thephez thephez approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17
Development

Successfully merging this pull request may close these issues.
4 participants
@UdjinM6 @PastaPastaPasta @thephez @xdustinface