chainlocks: Fix potential deadlock #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix this: ``` Previous lock order was: pnode->cs_sendProcessing net.cpp:2854 cs_main net_processing.cpp:3946 (TRY) mempool.cs net_processing.cpp:4183 (1) pto->cs_inventory net_processing.cpp:4183 pto->cs_filter net_processing.cpp:4233 (2) cs llmq/quorums_chainlocks.cpp:87 Current lock order is: cs_main llmq/quorums_chainlocks.cpp:138 (2) cs llmq/quorums_chainlocks.cpp:138 cs_vNodes net.cpp:3662 (1) cs_inventory ./net.h:1085 ```
xdustinface
reviewed
Jan 30, 2021
There was a problem hiding this comment.
Couldn't we then also move InternalHasConflictingChainLock up into the other LOCK(cs) scope (without negative side effects?) like in 5b520c3?
|
I guess 5b520c3 makes sense. Just not in this PR :) |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 1, 2022
Should fix this: ``` Previous lock order was: pnode->cs_sendProcessing net.cpp:2854 cs_main net_processing.cpp:3946 (TRY) mempool.cs net_processing.cpp:4183 (1) pto->cs_inventory net_processing.cpp:4183 pto->cs_filter net_processing.cpp:4233 (2) cs llmq/quorums_chainlocks.cpp:87 Current lock order is: cs_main llmq/quorums_chainlocks.cpp:138 (2) cs llmq/quorums_chainlocks.cpp:138 cs_vNodes net.cpp:3662 (1) cs_inventory ./net.h:1085 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this: