Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat!: use semantic error codes #397

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 9, 2021

Issue being fixed or feature implemented

To allow more logical error handling for clients, we need to use semantically correct error codes for different cases.

What was done?

  • Use NotFound, FailedPrecondition, and InvalidArgument in places where it makes sense

How Has This Been Tested?

With tests

Breaking Changes

  • Some endpoints respond with different error codes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.0 milestone Aug 9, 2021
@shumkov shumkov requested review from shuplenkov and jawid-h August 9, 2021 11:40
@shumkov shumkov merged commit ed5db51 into v0.21-dev Aug 10, 2021
@shumkov shumkov deleted the use-semantic-error-codes branch August 10, 2021 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants