Element Picker for Per-Site Exclusion Rules #48
Comments
|
Being able to pick elements (or adding the XPATH or selector rules on a site) would be super useful. There are elements that are already "darker" and I don't want it to have inverted colors (like the gitlab.com code highlighted blocks). |
|
I've started to work on another inversion engine, so I hope that specific per-site fixes should have gone. There are so many specific cases, so I think it's too hard to create such a picker, and create a system, that will auto-merge the fixes. So, currently it's faster to open Chrome Dev Tools, determine a selector for elements, that shouldn't be inverted, and add it here https://github.com/alexanderby/darkreader/blob/master/src/config/sites_fixes_v2.json |
|
Maybe Chrome Dev Tools picker it a better choice, because more information is needed to determine which selector suits better. Here is an updated doc for modifying per-site fixes https://github.com/alexanderby/darkreader#how-to-contribute |
|
why not copy the one from ublock origin? |
License and we will be publicly shamed for stealing code :). |
|
cant they just switch from mit to gpl? |
That is not how it work... |
|
I desperately want this to be added |
|
Honestly, this not being implemented in some form is the only thing keeping me from using this extension on a regular basis. Navigating through the dev tools just to fix one part of a page is a frustrating experience. |
Hi, just discovered Dark Reader, and it's great. I didn't see this in the issues, but I'd be interested seeing what the interest/feelings are on support for more extensive per-site customization/overrides.
Ideally, it'd be nice to be able to adjust some of the rules (like contrast) on a per-site level, and on a per-element basis (using an element picker) - is anyone using Dark Reader w/ Stylish? Maybe there's easy ways to carve out exclusions that way.
Otherwise I'd be interesting in forking and doing some work on a version that has some of this functionality, maybe also making the ignore/darksites JSON file be something that could auto-update/be customized - I see some pull requests there? Just wanted to see what you think before I get started @alexanderby
What's the darkreader license btw? There are some plugins that already have some functionality, but uBlock for example is GPLv3, and there might be other code that'd be useful that's MIT licensed.
The text was updated successfully, but these errors were encountered: